Change uint aliases to just be subclasses #1216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change uint aliases to just be subclasses do not override init with no-op.
old (note that the ellipsis here is not for code showing purposes, it's python code):
new:
The subclassing works just fine, and does not have all the edge-cases to think about when overriding the
__init__
. Also enables (read: makes IDE type hint checker happy) us to doValidatorIndex(123)
instead ofValidatorIndex(uint64(123))
.Also experimented with the use of
__metaclass__
orElements.elem_type
,ElementsType.elem_type
in type hinting. Intellij + Mypy are happy (surprisingly), but Python is not. So we would have to shadow the bahavior ofGeneric
to do that kind of type-hinting. That is for another time, construction of types and passing them is the most important now. The getter/setter/iteration is not even picked up as a problem by mypy, while it could be better (if Python allowed us to).And fixed an old
validator_registry
reference, which was missed (genesis trigger testing is in progress I believe)